| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | base: Annotate output with job information....Before this change, it was difficult to discern which job emitted which
output, as there was no information connecting the job to the output it
produced. This change rectifies that by annotating each line output by
cron/mcron with a prefix that contains a timestamp and the job name. It also
reports about when the job runs and whether it completed successfully or
failed. It was initially suggested here: <https://issues.guix.gnu.org/36510>.
Thanks to the fine people from the #guile libera.chat IRC channel for
providing ideas and help; this change would not have been possible without
them!
* src/mcron/base.scm (install-suspendable-ports!): Install suspendable ports.
(%date-format, %log-format): New parameters.
(validate-date-format, validate-log-format): New procedures.
(<job-data>): New record.
(run-job): Update doc. Redirect stdout and stderr to a pipe. Return a
<job-data> instance containing the input port and other information about the
job. Output job status messages.
(process-output): New procedure.
(child-cleanup): Add docstring. Use positive logic. Call 'process-output'
one last time after a child process is collected.
(run-job-loop): Add a CHILDREN-DATA variable to the loop. Provide the open
file descriptors of the children ports to select*, and collect their output
when they trigger select.
* tests/base.scm ("run-job: basic"): Adjust and fix indentation.
(dummy-job/capture-output): New procedure.
("run-job, output"): New test.
("validate-date-format, valid", "validate-date-format, invalid")
("validate-log-format, valid", "validate-log-format, invalid")
("run-job, output with custom format", "run-job, failure")
("run-job, failure in shell action"): New tests.
* src/mcron/scripts/cron.scm (show-help): Document new options.
(%options) [log-format, date-format]: New options.
(main): Parameterize the main loop with the new parameter options (or their
default values when not provided); move exception handling elsewhere (see
below).
* src/mcron/scripts/mcron.scm: Likewise.
* src/cron.in: Install error handler here.
* src/mcron.in: Likewise.
* doc/mcron.texi: Document new cron and mcron options, as well as new
(mcron base) APIs.
* tests/basic.sh: Test the new options.
Suggested-by: Robert Vollmert <rob@vllmrt.net>
| Maxim Cournoyer | 2022-07-07 | 2 | -14/+105 |
| * | project: banish need for C compiler...This patch gets rid of the thin veneer that we currently have around the three
executables. This was done for historical reasons (circa 2003 Guile couldnʼt
deal with process signals and forks). In fact these problems were fixed many
moons ago, and there is now no need for it. The project becomes 100% Guile!
Many files are affected; interested coders should use the GIT repository to
understand the details of all the changes.
| Dale Mellor | 2020-04-20 | 1 | -7/+6 |
| * | test: demonstrate incorrect -s option on mcron program...The option is supposed to be able to take an optional argument, but if the
argument is not supplied (should default to 8) then the test, rather than
failing, is skipped with a friendly message in the log file. The proper fix
will come with an upstream patch to GNU Guile, and a future version of Mcron.
* tests/schedule-2.sh: new test, new file
* Makefile.am: make sure to run the new test file
| Dale Mellor | 2020-04-20 | 1 | -0/+82 |
| * | test: Demonstration of failure to open local file....The mcron program goes looking for files specified on the command
line in Guile's module path, inevitably resulting in failure to load
said file. Running 'make check' will show at least one failure.
* tests/basic.sh: Added new test.
| Dale Mellor | 2020-04-20 | 1 | -0/+3 |
| * | test: make date tests reliable, i.e. independent of current time...Some of the date tests depend both on the particular time of day and year at
which the test is run, and also on the state of daylight-savings adjustments.
(At the present time on my system there are four failing tests, but YMMV.)
This patch puts all the tests to UTC time in the C locale, making the results
consistent. *All* items in the test suite should be passing once again.
* tests/job-schedule.scm: Fix up the environment before running the tests.
| Dale Mellor | 2020-04-20 | 2 | -18/+17 |
| * | tests: Add "tests/vixie-time.scm"...* tests/vixie-time.scm: New test.
* Makefile.am (TESTS): Add it.
| Mathieu Lirzin | 2018-04-08 | 1 | -0/+118 |
| * | utils: Check 'show-version' and 'show-package-information'...* tests/utils.scm ("show-package-information")
("show-version"): New tests.
| Mathieu Lirzin | 2018-03-27 | 1 | -0/+18 |
| * | job-specifier: Check 'job'...* tests/job-specifier.scm ("job: procedure timeproc")
("job: list timeproc", "job: string timeproc", "job: list action")
("job: invalid string timeproc", "job: invalid timeproc")
("job: procedure action", "job: string action")
("job: user name"): New tests.
| Mathieu Lirzin | 2018-03-27 | 1 | -0/+37 |
| * | job-specifier: Box 'configuration-user' global variable...* src/mcron/job-specifier.scm (configuration-user): Box it using
SRFI-111 to be explicit about the mutability of this object.
(job): Adapt.
(set-configuration-user): Adapt and use 'get-user'.
* tests/job-specifier.scm ("set-configuration-user: passwd entry")
("set-configuration-user: invalid uid", "set-configuration-user: uid")
("set-configuration-user: invalid spec")
("set-configuration-user: name"): New tests.
| Mathieu Lirzin | 2018-03-27 | 1 | -0/+46 |
| * | job-specifier: Check 'next-...' procedures...* tests/job-specifier.scm ("next-year", "next-month", "next-day")
("next-hour", "next-minute", "next-second"): New tests.
("next-hour-from"): Remove.
| Mathieu Lirzin | 2018-03-27 | 1 | -3/+36 |
| * | base: Check how child processes are handled...* tests/base.scm ("run-job: basic"): Check the number of children too.
("child-cleanup: one", "update-number-children!: set value"): New tests.
| Mathieu Lirzin | 2018-03-26 | 1 | -6/+23 |
| * | job-specifier: Adapt 'bump-time' to 'next-...-from' procedures...This is a follow-up to commit 913e3c65e4f56476e8ac69f4892cf92c125751ec.
Since 'next-...-from' procedures now uses an '#:optional' argument
instead of a dotted optional arguments list, 'bump-time' doesn't need to
unwrap VALUE-LIST anymore.
* src/mcron/job-specifier.scm (bump-time): Pass VALUE-LIST directly to
'%find-best-next'.
* tests/job-specifier.scm ("next-hour-from"): New test.
* NEWS: Update.
Reported-by: Ludovic Courtès <ludo@gnu.org>
| Mathieu Lirzin | 2018-03-26 | 1 | -0/+4 |
| * | job-specifier: Preserve '%find-best-next' arguments exactness...The behavior of the 'min' procedure which converts its parameters to
inexact numbers when at least one of them is inexact was causing
'%find-best-next' to always return real numbers.
* src/mcron/job-specifier.scm (%find-best-next): Preserve the exactness
of numbers in NEXT-LIST.
* tests/job-specifier.scm ("%find-best-next: exact"): New test.
Reported-by: Ludovic Courtès <ludo@gnu.org>
| Mathieu Lirzin | 2018-03-26 | 1 | -1/+10 |
| * | utils: Check 'mcron-error'...* tests/utils.scm ("mcron-error: exit code", "mcron-error: output")
("mcron-error: output no-exit", "mcron-error: only stderr"): New tests.
| Mathieu Lirzin | 2018-03-25 | 1 | -1/+43 |
| * | tests: Add "tests/utils.scm"...* tests/utils.scm: New test.
* Makefile.am (TESTS): Add it.
| Mathieu Lirzin | 2018-03-25 | 1 | -0/+51 |
| * | tests: Remove unused schedule stubs...* tests/base.scm ("number-children: init")
("update-number-children!: 1+", "update-number-children!: 1-"): Remove
'let' form defining the schedule stub.
| Mathieu Lirzin | 2018-03-24 | 1 | -13/+12 |
| * | environment: Check configuration environment...* tests/environment.scm ("current-environment-mods-copy: empty")
("current-environment-mods: init", "append-environment-mods: basic")
("append-environment-mods: twice", "clear-environment-mods: effect")
("current-environment-mods-copy: basic"): New tests.
| Mathieu Lirzin | 2018-03-24 | 1 | -1/+54 |
| * | base: Check 'run-job'...* tests/base.scm ("run-job: basic"): New test.
| Mathieu Lirzin | 2018-03-24 | 1 | -0/+16 |
| * | base: Box 'number-children'...* src/mcron/base.scm (number-children): Box it using SRFI-111 to be
explicit about the mutability of this object.
(update-number-children!): New procedure.
(run-job, child-cleanup): Use it.
* tests/base.scm ("update-number-children!: 1+")
("number-children: init", "update-number-children!: 1-"): New tests.
| Mathieu Lirzin | 2018-03-24 | 1 | -0/+32 |
| * | tests: Add "tests/base.scm"...* tests/base.scm: New test.
* Makefile.am (TESTS): Add it.
| Mathieu Lirzin | 2018-03-24 | 1 | -0/+151 |
| * | utils: Use 'scandir' instead of custom 'for-each-file'...* src/mcron/utils.scm (for-each-file): Delete.
* src/mcron/scripts/cron.scm (process-files-in-system-directory): Use
'scandir' which has the benefit of being deterministic.
* src/mcron/scripts/mcron.scm (process-files-in-user-directory):
Likewise.
* tests/schedule.sh: Update expected output which is now more reliable.
* NEWS: Update.
Suggested-by: Ludovic Courtès <ludo@gnu.org>
| Mathieu Lirzin | 2018-03-20 | 1 | -13/+13 |
| * | tests: Set timezone in "schedule.sh"...Previously the test environment was implicitly expecting the current
timezone to be UTC+1.
* tests/schedule.sh: Set TZ environment variable to 'UTC0'.
Update expected result.
Reported-by: Ludovic Courtès <ludo@gnu.org>
| Mathieu Lirzin | 2018-03-20 | 1 | -21/+26 |
| * | tests: Add 'schedule.sh'...* tests/schedule.sh: New test.
* Makefile.am (TESTS): Add it.
* src/mcron/job-specifier.scm (configuration-time): Use
SOURCE_DATE_EPOCH for reproducible tests.
| Mathieu Lirzin | 2018-03-16 | 1 | -0/+123 |
| * | tests: Add 'basic.sh'...* tests/init.sh: New test framework from Gnulib.
* tests/basic.sh: New test.
* Makefile.am (TESTS): Add it.
(TEST_EXTENSIONS): Add '.sh'.
(SH_LOG_COMPILER): Use 'pre-inst-env'.
(EXTRA_DIST): Add 'tests/init.sh'.
* build-aux/pre-inst-env.in: export $srcdir for shell tests.
| Mathieu Lirzin | 2017-09-28 | 2 | -0/+638 |
| * | environment: modify-environment: Add tests....* tests/environment.scm: New test.
* Makefile.am (TESTS): Add it.
| Mathieu Lirzin | 2016-12-01 | 1 | -0/+39 |
| * | job-specifier: range: Add tests....* build-aux/test-driver.scm: New script.
* configure.ac (AC_REQUIRE_AUX_FILE): Add it.
* tests/job-specifier.scm: New test.
* Makefile.am (TEST_EXTENSIONS, AM_TESTS_ENVIRONMENT, SCM_LOG_DRIVER)
(TESTS): New variables.
(EXTRA_DIST): Update.
* .gitignore: Likewise.
| Mathieu Lirzin | 2016-12-01 | 1 | -0/+43 |
