AboutSummaryRefsLogTreeCommitDiffStats
diff options
context:
space:
mode:
authorulfvonbelow <striness@tilde.club>2023-02-02 19:29:49 +0000
committerDale Mellor <mcron-lsfnyl@rdmp.org>2023-03-18 14:00:26 +0000
commit48b8d47ca245a7837af593f14e688ee04720f68a (patch)
tree1457f6e8e078768ccf0a263d1b960cd08df6b4bc
parent63443d075057c31322e1f3414c2d74bbf9f37bac (diff)
downloadmcron-48b8d47ca245a7837af593f14e688ee04720f68a.tar.gz
mcron-48b8d47ca245a7837af593f14e688ee04720f68a.tar.bz2
mcron-48b8d47ca245a7837af593f14e688ee04720f68a.zip
Makefile.am: don't install cron as setuid.
Setuid scripts are disabled on most systems anyway. Also cron refuses to run if the real user id isn't 0, so there's no point in it being setuid anyway. Also also, no attempt at controlling the environment has been made, so even if the symlink race conditions that make setuid scripts vulnerable were resolved, it would still be unsafe.
-rwxr-xr-xMakefile.am3
1 files changed, 1 insertions, 2 deletions
diff --git a/Makefile.am b/Makefile.am
index 09a0d6d..a9ef5a9 100755
--- a/Makefile.am
+++ b/Makefile.am
@@ -168,8 +168,7 @@ install-exec-hook:
if MULTI_USER
tcrontab=`echo crontab | sed '$(transform_exe)'`; \
chmod u+s $(DESTDIR)$(bindir)/$${tcrontab}
- tcron=`echo cron | sed '$(transform_exe)'`; \
- chmod u+s $(DESTDIR)$(sbindir)/$${tcron}
+ tcron=`echo cron | sed '$(transform_exe)'`;
endif
tmcron=`echo mcron | sed '$(transform_exe)'`;